Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize sidebar before starting to write solution level docs #91
Reorganize sidebar before starting to write solution level docs #91
Changes from 7 commits
b9a80e8
f712cbe
43faf79
5455755
7295f0f
73697b6
b6560c8
82b81b3
e2a18b1
999a10c
e14c2e1
8c61ba9
3c7ee1a
4d85958
be29b1b
7081d8c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could link https://www.suse.com/products/micro/ or perhaps better https://documentation.suse.com/sle-micro here?
I've also been wondering if we should test with LeapMicro e.g https://github.com/suse-edge/metal3-demo currently uses Leap, so it would be a more logical move to switch that to LeapMicro for upstream/community usage, or we can just document how to get the SLEMicro image instead (which is probably OK but not ideal from a community perspective).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's chat about this once I'm back from PTO. It's an interesting thought but I'd like to make sure that Leap Micro and SLE Micro maintain the same ABI compatibility that SLES and Leap do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now this seems fine in the integrations section, but I wonder if we need a separate development section for this kind of content and other contributor guidelines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's chat about where to put contributor guides separately