Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LiveStream class for managing live queries #78

Closed

Conversation

jonathanrbarney
Copy link

@jonathanrbarney jonathanrbarney commented Dec 2, 2023

What is the motivation?

To Add support for Live Query result fetching

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

What does this change do?

This change implements initial support for live queries and listening to the result stream rather than simply returning the live query ID as the SDK currently does.

Note that the limitation of one live query per Surreal class instance and associated required connection state changes is a result of the current implementation choice to use the connection in a blocking way with _send_receive. Multiplexing of multiple live query streams is possible with custom listener handling routing for received messages and use of callbacks but represents a fundamental change to the way this SDK currently operates which is why I chose not to implement it.

Is this related to any issues?

#34

Have you read the Contributing Guidelines?

@jonathanrbarney jonathanrbarney mentioned this pull request Dec 4, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants