Remove index from non cacheable Form action #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
First sorry for what could looked like a messy commit history. Didn't get this one started off in a branch, but the change is a one liner so I hope it's cool.
I'm not 100% sure if there's some downside with this but after trying various things, the was the only thing that worked.
Situation:
We run a signup form on all pages on the site creating the form using TS so we can show it in the footer and as a popover in some page views:
After moving to a new platform that includes Varnish caching, we noticed that all pages were missing the cache and so a
USER_INT
must be in play. Revising everything it turns out that the form is being created asUSER_INT
for some reason I don't understand.Seems like there's no reason for that and so this PR is to remove it from the configurePlugin, as it will then render as a
USER
object.If there's another way to force it as a
USER
without changing this, please let me know but I did some tests and it looks like the form works just fine (both with and without AJAX enabled) running asUSER
.