Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SSAO correct #5249

Merged
merged 9 commits into from
Jan 18, 2025
Merged

Conversation

CodingJellyfish
Copy link
Member

How could the current SSAO avaliable to users?

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

@CodingJellyfish
Copy link
Member Author

Before:
image

After:
image

@Alayan-stk-2
Copy link
Collaborator

The SSAO visualization looks a lot better with the changed code! I'll have to test in-game to see the effect of the change on the general look of a track.

Obviously a more correct implementation is preferred, but are you expecting a change in performance behavior? I guess we'll have to test, it's useful to know about even if it won't change the decision to merge.

@CodingJellyfish
Copy link
Member Author

CodingJellyfish commented Jan 17, 2025

The SSAO visualization looks a lot better with the changed code! I'll have to test in-game to see the effect of the change on the general look of a track.

Obviously a more correct implementation is preferred, but are you expecting a change in performance behavior? I guess we'll have to test, it's useful to know about even if it won't change the decision to merge.

The performance is overall doubled.
Edit: Theoretically. Actually slightly worse because the old one is lame.
Edit again: Now it should be better than before.

@CodingJellyfish
Copy link
Member Author

Now it looks like
image

@CodingJellyfish CodingJellyfish merged commit b180a49 into supertuxkart:master Jan 18, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants