Removed glow under main menu options

[MollyMaclachlan]

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

This follows the proposal in #5109 to remove the glow under the five main menu options, and derives its approach from the recommendation given when #5222 was closed.

To see if an icon button has a focus image specified, I check if the size of m_properties[PROP_FOCUS_ICON] exceeds 0, as is done when assinging m_highlight_texture in icon_button_widget.cpp.

[Alayan-stk-2]

From a glance at your code, you seem to set use_square to true by default, and then rely on the if/else if structure to ensure that the code meant for use_square=true is not used by things that should use the glow and not the square highlight.

This may work as is, but the name of the variable and the content of the variable not matching when the variable is used is susceptible to cause trouble down the line if surrounding code is changed.

It's cleaner to ensure the variables get values that match their meaning when setting them up at the beginning, so that they can be used later without the danger of running into gotchas.

[MollyMaclachlan]

Thanks for the feedback. I've updated the approach to use the widget->m_properties[PROP_FOCUS_ICON].size() check to avoid having mark_focused set to true at all for widgets with a specified focus image; specifically, in my new code mark_focused is only set to true where a focus image is not specified. This seems more straightforward to me.

[CodingJellyfish]

The code looks good to me.

[CodingJellyfish]

Thank you so much for your contribution.