Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade c++ standard from gnu++0x to c++17 #5146

Closed
wants to merge 1 commit into from

Conversation

nyllet
Copy link
Contributor

@nyllet nyllet commented Aug 9, 2024

Make sure it builds for mingw. The WIN32 macro appears not to be set when building for mingw. However, MINGW32 is set for both 32-bit and 64-bit

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

Make sure it builds for mingw. The WIN32 macro appears not to be set when building for mingw. However, __MINGW32__ is set for both 32-bit and 64-bit
@nyllet
Copy link
Contributor Author

nyllet commented Aug 9, 2024

#5145 must be merged before this one, otherwise the macos builds will fail

@deveee
Copy link
Member

deveee commented Aug 11, 2024

I'm not keen to make such changes because I don't see real benefit and it usually breaks compilation. For example I build linux package using old debian for better compatibility.

@CodingJellyfish
Copy link
Member

Is there any progress on this? If not I guess I should close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants