Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a console warning if writing to cookies doesn't work #260

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

porcellus
Copy link
Collaborator

Summary of change

add a console warning if writing to cookies doesn't work

  • We check when saving the last access token update time
  • We only check once per reload (store the result in memory)
  • The warning is repeated on every access token update to increase the chances of devs noticing it.

Related issues

Test Plan

Added a new test that checks that this is logged

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Copy link

size-limit report 📦

Path Size
lib/build/bundleEntry.js 21.13 KB (+0.6% 🔺)

@porcellus porcellus merged commit 56fa018 into 20.1 Jun 14, 2024
4 checks passed
@porcellus porcellus deleted the fix/add_cookie_blocked_warning branch June 14, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant