feat: add threshold in DateProvider #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
rishabhpoddar
suggested changes
Jan 20, 2024
rishabhpoddar
suggested changes
Jan 20, 2024
rishabhpoddar
suggested changes
Jan 20, 2024
porcellus
approved these changes
Jan 23, 2024
rishabhpoddar
suggested changes
Jan 23, 2024
lib/ts/claims/primitiveArrayClaim.ts
Outdated
| @@ -131,7 +131,7 @@ export class PrimitiveArrayClaim<ValueType> { | |||
| id?: string | |||
| ): SessionClaimValidator => { | |||
| const DateProvider = DateProviderReference.getReferenceOrThrow().dateProvider; | |||
| if (maxAgeInSeconds && maxAgeInSeconds < DateProvider.getThresholdInSeconds()) { | |||
| if (maxAgeInSeconds !== undefined && maxAgeInSeconds < DateProvider.getThresholdInSeconds()) { | |||
There was a problem hiding this comment.
these checks should be in shouldRefresh
rishabhpoddar
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR adds a threshold in DateProvider to fix some breaking tests and ensure we only have clock skew when its significant enough.
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.jsonfile has been updated (if needed)lib/ts/version.tspackage.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.