fix: PR changes

supertokens · Jun 5, 2024 · 866a0f9 · 866a0f9
1 parent 6756e33
commit 866a0f9
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 5 deletions.
diff --git a/bundle/bundle.js b/bundle/bundle.js
diff --git a/lib/build/axios.js b/lib/build/axios.js
diff --git a/lib/build/xmlhttprequest.js b/lib/build/xmlhttprequest.js
diff --git a/lib/ts/axios.ts b/lib/ts/axios.ts
@@ -441,6 +441,10 @@ export default class AuthHttpRequest {
                     let response =
                         localPrevResponse === undefined ? await httpCall(configWithAntiCsrf) : localPrevResponse;
 
+                    // NOTE: No need to check for unauthorized response status here for session refresh,
+                    // as we only reach this point on a successful response. Axios handles error responses
+                    // by throwing an error, which is handled in the catch block.
+
                     logDebugMessage("doRequest: User's http call ended");
 
                     await saveTokensFromHeaders(response);

diff --git a/lib/ts/xmlhttprequest.ts b/lib/ts/xmlhttprequest.ts
@@ -249,9 +249,11 @@ export function addInterceptorsToXMLHttpRequest() {
                     // Here we only need to handle fetch related errors, from the refresh endpoint called by the retry
                     // So we should only get network level errors here
 
-                    const ev = new Event("error");
+                    const ev = new ProgressEvent("error");
                     (ev as any).error = err;
-                    self.dispatchEvent(ev);
+                    if (self.onerror !== undefined && self.onerror !== null) {
+                        self.onerror(ev);
+                    }
 
                     redispatchEvent("error", ev);
                 }