Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writes errors to stderr from container #359

Open
wants to merge 4 commits into
base: 3.8
Choose a base branch
from
Open

writes errors to stderr from container #359

wants to merge 4 commits into from

Conversation

yowayb
Copy link

@yowayb yowayb commented Jan 21, 2022

Summary of change

When running in a container without $ERROR_LOG_PATH specified, this change will now print errors to stderr (instead of being merged into stdout

Related issues

Test Plan

  1. docker run -p 3567:3567 supertokens 2> >(while read line; do echo -e "\e[01;31m$line\e[0m" >&2; done)
  2. curl 'http://localhost:3567/users/count?includeRecipeIds=thirdparty,random'
  3. Confirm error is colored red

image

Documentation changes

None

Checklist for important updates

  • Changelog has been updated
    • If there are any db schema changes, mention those changes clearly
  • coreDriverInterfaceSupported.json file has been updated (if needed)
  • pluginInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In build.gradle
  • Had installed and ran the pre-commit hook
  • If there are new dependencies that have been added in build.gradle, please make sure to add them in implementationDependencies.json.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

None

@rishabhpoddar
Copy link
Contributor

Hi @yowayb thanks for this fix. A few points:

  • Please update the changelog (you can create an unreleased section on the top)
  • I have updated the base branch to 3.8 since that's the latest release tag.
  • A similar change needs to be made for MySQL plugin, postgres plugin and for MongoDB plugin.

@rishabhpoddar rishabhpoddar changed the base branch from 3.9 to 3.8 January 22, 2022 06:50
@rishabhpoddar
Copy link
Contributor

Thanks @yowayb I will keep this PR open until similar changes have been made to the db plugins. Once those are done, I'll merge all and then release them as a new patch version.

Thank you once again. I have added you as a contributor in the supertokens-core repo's readme :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants