-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fuji as canary testnet, run in Nix shell #1373
Conversation
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #1373 +/- ##
==========================================
+ Coverage 88.23% 97.84% +9.60%
==========================================
Files 86 38 -48
Lines 4311 2092 -2219
Branches 180 0 -180
==========================================
- Hits 3804 2047 -1757
+ Misses 463 45 -418
+ Partials 44 0 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for nixifying workflows!
XKCD Comic RelifLink: https://xkcd.com/1373 |
This PR is about making workflows less flaky, mainly by avoiding the implicit fetching of additional binaries at runtime (after dependencies were installed):
tasks/shellcheck-all-tasks.sh
now checks if the binary exists in PATH (provided by Nix shell) and only prints a warning if not.CONTRIBUTING.md
- TODO: update the section Releases (seems outdated, not related to this PR though)