[ETHEREUM-CONTRACTS] don't claim as a side effect of updateMemberUnit…

…s() (#1883) * don't claim as a side effect of updateMemberUnits() * less wrong * fix surgery & adjust test
superfluid-finance · Mar 13, 2024 · 766630b · 766630b
1 parent b67c96a
commit 766630b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/packages/ethereum-contracts/contracts/agreements/gdav1/SuperfluidPool.sol b/packages/ethereum-contracts/contracts/agreements/gdav1/SuperfluidPool.sol
@@ -403,12 +403,7 @@ contract SuperfluidPool is ISuperfluidPool, BeaconProxiable {
 
         // update pool's disconnected units
         if (!GDA.isMemberConnected(ISuperfluidPool(address(this)), memberAddr)) {
-            // trigger the side effect of claiming all if not connected
-            // @note claiming is a bit surprising here given the function name
-            int256 claimedAmount = _claimAll(memberAddr, time);
-
-            // update pool's disconnected units
-            _shiftDisconnectedUnits(wrappedUnits - mu.m.owned_units, Value.wrap(claimedAmount), t);
+            _shiftDisconnectedUnits(wrappedUnits - mu.m.owned_units, Value.wrap(0), t);
         }
 
         // update pool member's units

diff --git a/packages/ethereum-contracts/test/foundry/FoundrySuperfluidTester.sol b/packages/ethereum-contracts/test/foundry/FoundrySuperfluidTester.sol
@@ -1617,11 +1617,11 @@ contract FoundrySuperfluidTester is Test {
 
         assertEq(pool_.getUnits(member_), newUnits_, "GDAv1.t: Members' units incorrectly set");
 
-        // Assert that pending balance is claimed if user is disconnected
+        // Assert that pending balance didn't change if user is disconnected
         if (!isConnected) {
             (int256 balanceAfter,,,) = poolSuperToken.realtimeBalanceOfNow(member_);
             assertEq(
-                balanceAfter, balanceBefore + claimableBalance, "_helperUpdateMemberUnits: Pending balance not claimed"
+                balanceAfter, balanceBefore, "_helperUpdateMemberUnits: Pending balance changed"
             );
         }