This repository has been archived by the owner on Sep 24, 2023. It is now read-only.
Porting to Python 3 #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should definetely include tox as opposed to python2 we need to test against a multiple of python 3 versions. I think we should at least support the python versions that are shipped with debian. |
|
thanks so much! this is super helpful. i'll try to review it by the end of the weekend. |
|
(closed/opened to trigger travis build) |
|
oh right, we've never used this repo's travis config. i'll test it with a branch in the supercollider repo. |
|
Any news on this? |
|
still planning to review it. it's a national holiday this week in the US so i'll try to get to it by the end of the month. |
|
@brianlheim any news on this? happy to help with any python coding concerning SC |
|
bump |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can close #4
There are a couple of bugs and anti-patterns which I found on skipping through and I would resolve those in another PR once this is merged.
Lets keep focused on the porting here.
There is a tests directory but sadly those tests don't do much so we need some manual testing because I don't comprehend the full usecase of this library in the build chain of SuperCollider.