Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add role-configs command to list db roles with custom settings #2818

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

encima
Copy link
Member

@encima encima commented Oct 30, 2024

What kind of change does this PR introduce?

Feature

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

New role-configs command under inspect to show all users that have a configuration that is different from the standard

Additional context

Useful for debugging and auditing

@encima encima force-pushed the feat/add-inspect-role-config branch from 2bb7234 to bbcc75d Compare October 30, 2024 14:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11595390911

Details

  • 15 of 26 (57.69%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 59.796%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/inspect.go 1 4 25.0%
internal/inspect/role_configs/role_configs.go 14 22 63.64%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11590629717: -0.03%
Covered Lines: 6376
Relevant Lines: 10663

💛 - Coveralls

Copy link

@carusocv carusocv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - may be worth getting 2nd from previous contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants