Remove max-age option from cookieOptions (#639)

supabase · Sep 16, 2023 · 66e6b4c · 66e6b4c
1 parent c48bb87
commit 66e6b4c
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 8 deletions.
diff --git a/.changeset/dirty-books-begin.md b/.changeset/dirty-books-begin.md
@@ -0,0 +1,5 @@
+---
+'@supabase/ssr': patch
+---
+
+Remove max-age option from cookieOptions
diff --git a/packages/ssr/src/createBrowserClient.ts b/packages/ssr/src/createBrowserClient.ts
@@ -70,31 +70,33 @@ export function createBrowserClient<
 					if (typeof cookies.set === 'function') {
 						return await cookies.set(key, value, {
 							...DEFAULT_COOKIE_OPTIONS,
-							...cookieOptions
+							...cookieOptions,
+							maxAge: DEFAULT_COOKIE_OPTIONS.maxAge
 						});
 					}
 
 					if (isBrowser()) {
 						document.cookie = serialize(key, value, {
 							...DEFAULT_COOKIE_OPTIONS,
-							...cookieOptions
+							...cookieOptions,
+							maxAge: DEFAULT_COOKIE_OPTIONS.maxAge
 						});
 					}
 				},
 				removeItem: async (key: string) => {
 					if (typeof cookies.remove === 'function') {
 						return await cookies.remove(key, {
 							...DEFAULT_COOKIE_OPTIONS,
-							maxAge: 0,
-							...cookieOptions
+							...cookieOptions,
+							maxAge: 0
 						});
 					}
 
 					if (isBrowser()) {
 						document.cookie = serialize(key, '', {
 							...DEFAULT_COOKIE_OPTIONS,
-							maxAge: 0,
-							...cookieOptions
+							...cookieOptions,
+							maxAge: 0
 						});
 					}
 				}

diff --git a/packages/ssr/src/createServerClient.ts b/packages/ssr/src/createServerClient.ts
@@ -53,9 +53,13 @@ export function createServerClient<
 			storage: {
 				getItem: async (key: string) => (await cookies.get(key)) ?? null,
 				setItem: async (key: string, value: string) =>
-					await cookies.set(key, value, { ...DEFAULT_COOKIE_OPTIONS, ...cookieOptions }),
+					await cookies.set(key, value, {
+						...DEFAULT_COOKIE_OPTIONS,
+						...cookieOptions,
+						maxAge: DEFAULT_COOKIE_OPTIONS.maxAge
+					}),
 				removeItem: async (key: string) =>
-					await cookies.remove(key, { ...DEFAULT_COOKIE_OPTIONS, maxAge: 0, ...cookieOptions })
+					await cookies.remove(key, { ...DEFAULT_COOKIE_OPTIONS, ...cookieOptions, maxAge: 0 })
 			}
 		}
 	};