Fix malformed array literal cause by Overalps func #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrays in Postgres use this string format '{10000, 10000, 10000, 10000}' or '{"meeting", "lunch"}'
https://www.postgresql.org/docs/current/arrays.html
muratmirgun
reviewed
Jan 6, 2024
filterbuilder.go
Outdated
| @@ -196,7 +196,13 @@ func (f *FilterBuilder) RangeAdjacent(column, value string) *FilterBuilder { | |||
| } | |||
|
|
|||
| func (f *FilterBuilder) Overlaps(column string, value []string) *FilterBuilder { | |||
| f.params[column] = "ov." + strings.Join(value, ",") | |||
| _new := []string{} | |||
There was a problem hiding this comment.
just change here like "new" we not use '_' from variables and other sides looks good thanks for help
There was a problem hiding this comment.
K cool changed it to newValue and no prob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.postgresql.org/docs/current/arrays.html
What kind of change does this PR introduce?
Correctly formatting the array used by the Overlap function
Bug fix, feature, docs update, ...
Arrays in Postgres use this string format '{10000, 10000, 10000, 10000}' or '{"meeting", "lunch"}'
What is the current behavior?
value
[]string{"foo", "bar"}turns intofoo barPlease link any relevant issues here.
Seeding database error while running locally
What is the new behavior?
Will turn values
[]string{"foo", "bar"}into'{"foo", "bar"}'Additional context
https://www.postgresql.org/docs/current/arrays.html