fix(imports): only import matplotlib where needed and if gui is enabled #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjayankur31
added a commit
to NeuroML/pyNeuroML
that referenced
this pull request
Nov 2, 2023
Note: remove these functions from pynml in the future See also: suny-downstate-medical-center/netpyne#787
This is required to prevent matplotlib from being imported on HPCs.
|
Thanks @sanjayankur31. Merging to neuroml branch so we can get this on osb (so we can run it on nsg)... |
pgleeson
merged commit 9dd3591
into
suny-downstate-medical-center:neuroml_updates
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #786
CC @pgleeson