Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pin of chromedriver and remove webdrivers gem #2342

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Remove pin of chromedriver and remove webdrivers gem #2342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ group :development, :test do
gem 'factory_bot_rails'
gem 'rails-controller-testing'
gem 'capybara'
gem 'webdrivers'
gem 'selenium-webdriver', '!= 3.13.0'
gem 'simplecov', require: false
gem 'webmock'
Expand Down
7 changes: 1 addition & 6 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ GEM
sprockets-rails
tilt
scrub_rb (1.0.1)
selenium-webdriver (4.10.0)
selenium-webdriver (4.11.0)
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 3.0)
websocket (~> 1.0)
Expand Down Expand Up @@ -780,10 +780,6 @@ GEM
activemodel (>= 6.0.0)
bindex (>= 0.4.0)
railties (>= 6.0.0)
webdrivers (5.2.0)
nokogiri (~> 1.6)
rubyzip (>= 1.3.0)
selenium-webdriver (~> 4.0)
webmock (3.18.1)
addressable (>= 2.8.0)
crack (>= 0.3.2)
Expand Down Expand Up @@ -885,7 +881,6 @@ DEPENDENCIES
tzinfo-data
uglifier (>= 2.7.2)
web-console (>= 4.1.0)
webdrivers
webmock

BUNDLED WITH
Expand Down
4 changes: 0 additions & 4 deletions spec/rails_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@

require 'selenium-webdriver'

# I think this line can be removed when selenium 4.11 is released
# See https://github.com/titusfortner/webdrivers/issues/247#issuecomment-1648154088
Webdrivers::Chromedriver.required_version = '114.0.5735.90'

Capybara.javascript_driver = :selenium_chrome_headless

# Requires supporting ruby files with custom matchers and macros, etc, in
Expand Down