Merge pull request #2610 from sul-dlss/2609-role-facet-label

Change Role facet label

app/controllers/catalog_controller.rb

@@ -186,7 +186,7 @@ class CatalogController < ApplicationController
     config.add_facet_field 'pub_year_tisim', label: 'Date Range', range: true
     config.add_facet_field 'language', label: 'Language', limit: true
     config.add_facet_field 'name_ssim', label: 'Creators/Contributors', limit: true
-    config.add_facet_field 'name_roles_ssim', label: 'Role', limit: -1,
+    config.add_facet_field 'name_roles_ssim', label: 'Creators/Contributors by role', limit: -1,
                                               component: Blacklight::Hierarchy::FacetFieldListComponent,
                                               item_presenter: RoleFacetItemPresenter
     config.add_facet_field 'author_person_facet', label: 'Author', limit: true # includes Collectors

spec/features/hierarchy_spec.rb

@@ -14,10 +14,10 @@
     page.driver.browser.manage.window.resize_to(1000, 400)
   end
 
-  it 'has the Role facet' do
-    expect(page).to have_button('Role')
+  it 'has the Creators/Contributors by role facet' do
+    expect(page).to have_button('Creators/Contributors by role')
 
-    click_button 'Role'
+    click_button 'Creators/Contributors by role'
 
     within '.blacklight-name_roles_ssim' do
       expect(page).to have_content('Artist')
@@ -32,10 +32,10 @@
     expect(page).to have_css('.filter-value', text: 'Artist: Pellegrini, Domenico, 1759-1840')
   end
 
-  it 'excludes empty roles from the Role facet' do
-    expect(page).to have_button('Role')
+  it 'excludes empty roles from the Creators/Contributors by role facet' do
+    expect(page).to have_button('Creators/Contributors by role')
 
-    click_button 'Role'
+    click_button 'Creators/Contributors by role'
 
     within '.blacklight-name_roles_ssim' do
       roles = find_all('li').map(&:text)