Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update About Section UI and Fix Google Summer of Code Link #643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Devmoni
Copy link
Contributor

@Devmoni Devmoni commented Jan 16, 2025

Changes:

  • Improved UI design of the About section.
  • Updated Google Summer of Code link to the direct GitHub URL.

Reason:

  • The previous link redirected to a wiki page, causing unnecessary extra steps for users.

- Made minor UI adjustments to improve the design of the About section.
- Replaced the existing Google Summer of Code link with the direct GitHub link to eliminate the unnecessary redirection.
@Devmoni
Copy link
Contributor Author

Devmoni commented Jan 16, 2025

Before image In your change image

Give some margin/padding to another Projects section

It looks fine on my machine.

image

@uditjainstjis
Copy link

Yeah I reloaded this section was fine.

Before image In your change image
Give some margin/padding to another Projects section

It looks fine on my machine.

image

@uditjainstjis
Copy link

i have reviewed this PR and tested, it is good to merge after extra line at EOF is removed.

@Devmoni
Copy link
Contributor Author

Devmoni commented Jan 16, 2025

i have reviewed this PR and tested, it is good to merge after extra line at EOF is removed.

The additional line has been intentionally included as instructed earlier by @quozl .

@quozl
Copy link
Contributor

quozl commented Jan 16, 2025

@uditjainstjis please explain why you would want the last newline of a file removed? It is our convention to end files with newlines unless the file comes from an upstream which does not. Missing newlines disrupts shell prompt after cat(1).

@uditjainstjis
Copy link

sorry, i misunderstood earlier, looks good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants