fix: resolve docById undefined error #4295
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yep. this is correct. |
|
This does resolve the issue. But note that the onResize method is getting called before the stage is set up, so we probably want to test that this.stage !== undefined. We can do that in a separate PR |
walterbender
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #4292
fix: resolve docById undefined error by ensuring utils.js loads before activity.js
The error "ReferenceError: docById is not defined" was occurring in activity.js
because it was trying to use docById before utils.js was fully loaded. Fixed
this race condition by explicitly ordering module dependencies in RequireJS
to ensure utils.js loads before activity.js.