Error handling to afterSaveLilypondPDF Method

index.html

@@ -539,7 +539,7 @@
                     <input type="checkbox" id="guitarCheck" tabindex="-1" />
                     <p></p>
                     <p><button id="submitLilypond"></button></p>
-                    <!-- <button id="submitPDF"></button></p> -->
+                    <!-- <p><button id="submitPDF"></button></p> -->
                 </div>
             </div>
 

js/SaveInterface.js

@@ -409,6 +409,8 @@ class SaveInterface {
         docById("guitarText").textContent = _("Include guitar tablature output?");
         //.TRANS: Lilypond is a scripting language for generating sheet music
         docById("submitLilypond").textContent = _("Save as Lilypond");
+        //.TRANS: LilypondPDF option
+        // docById("submitPDF").textContent = _("Save as Lilypond PDF");
         docById("fileName").value = filename;
         if (activity.PlanetInterface !== undefined) {
             docById("title").value = activity.PlanetInterface.getCurrentProjectName();
@@ -429,12 +431,9 @@ class SaveInterface {
         docById("submitLilypond").onclick = () => {
             activity.save.saveLYFile(false);
         };
-        // if (this.planet){
-        //     docById('submitPDF').onclick = function(){this.saveLYFile(true);}.bind(this);
-        //     docById('submitPDF').disabled = false;
-        // } else {
-        //     docById('submitPDF').disabled = true;
-        // }
+        // docById("submitPDF").onclick = () => {
+        //     activity.save.saveLYFile(true); // Set isPDF to true for PDF generation
+        // };        
         docByClass("close")[0].onclick = () => {
             activity.logo.runningLilypond = false;
             docById("lilypondModal").style.display = "none";
@@ -466,8 +465,14 @@ class SaveInterface {
         const guitarCheck = docById("guitarCheck").checked;
 
         if (filename != null) {
-            if (fileExt(filename) !== "ly") {
-                filename += ".ly";
+            if(!isPDF){
+                if (fileExt(filename) !== "ly") {
+                    filename += ".ly";
+                }
+            } else {
+                if (fileExt(filename) !== "pdf") {
+                    filename += ".pdf";
+                }
             }
         }
 
@@ -579,7 +584,6 @@ class SaveInterface {
         this.download("ly", "data:text;utf8," + encodeURIComponent(lydata), filename);
     }
 
-
     /**
      * Perform actions after saving a Lilypond file in PDF format.
      *
@@ -593,14 +597,20 @@ class SaveInterface {
      * @instance
      */
     afterSaveLilypondPDF(lydata, filename) {
+        filename = docById("fileName").value;
         document.body.style.cursor = "wait";
         window.Converter.ly2pdf(lydata, (success, dataurl) => {
             document.body.style.cursor = "default";
             if (!success) {
                 // eslint-disable-next-line no-console
                 console.debug("Error: " + dataurl);
-                //TODO: Error message box
+                // Error message handling if needed
+                const tmp = jQuery("<textarea />").appendTo(document.body);
+                this.activity.textMsg(
+                    _("Oops. Looks like we couldn’t save your music as a PDF. ") 
+                );             
             } else {
+                // Download the generated PDF
                 this.activity.save.download("pdf", dataurl, filename);
             }
         });

js/activity.js

@@ -1512,6 +1512,7 @@ class Activity {
                 activity.save.saveLilypond.bind(activity.save),
                 activity.save.saveLilypond.bind(afterSaveLilypond),
                 activity.save.afterSaveLilypondLY.bind(activity.save),
+                activity.save.afterSaveLilypondPDF.bind(activity.save),
                 activity.save.saveAbc.bind(activity.save),
                 activity.save.saveMxml.bind(activity.save),
                 activity.save.saveBlockArtwork.bind(activity.save)

planet/js/ServerInterface.js

@@ -93,4 +93,4 @@ class ServerInterface {
 
     init() { };
 
-}
+}