Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common):[components] add WToggleSwitchRounded #299

Merged
merged 2 commits into from
Jan 22, 2023
Merged

feat(common):[components] add WToggleSwitchRounded #299

merged 2 commits into from
Jan 22, 2023

Conversation

Tushar98644
Copy link
Contributor

@Tushar98644 Tushar98644 commented Jan 22, 2023

Part of #272
fixes #295

Screenshot 2023-01-22 at 4 17 32 PM

Screenshot 2023-01-22 at 4 17 57 PM

@Tushar98644
Copy link
Contributor Author

Tushar98644 commented Jan 22, 2023

The previous pr kind of got messy so created a new one @meganindya

@meganindya meganindya merged commit 2d5b05a into sugarlabs:develop Jan 22, 2023
@meganindya
Copy link
Member

seems like your local git config email isn't synchronised with your github account

run in terminal

git config --global user.name "<YOUR NAME>"
git config --global user.email <YOUR EMAIL>

@Tushar98644
Copy link
Contributor Author

seems like your local git config email isn't synchronised with your github account

run in terminal

git config --global user.name "<YOUR NAME>"
git config --global user.email <YOUR EMAIL>

done...... also i had one question, can we create issues for adding new react components ?

@meganindya
Copy link
Member

We're discussing the expected UI. Currently, I made a quick draft UI just to get started. No point in creating components that may not be utilised.

@Tushar98644
Copy link
Contributor Author

We're discussing the expected UI. Currently, I made a quick draft UI just to get started. No point in creating components that may not be utilised.

okay...will start working on wcheckbox and wIconbutton now...

@Tushar98644
Copy link
Contributor Author

@meganindya what should the callbackfunction on buttonclick be set to? set it to some undefined function or link to the same element?

@meganindya
Copy link
Member

not sure I understand

@Tushar98644
Copy link
Contributor Author

not sure I understand

I mean the handleclicker of WIconbutton

@meganindya
Copy link
Member

handlerClick will be a callback function passed as a prop. This is exactly like WTextButton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement of Toggle switch UI
2 participants