Modify ci.yml 'on' to run on pull request; Add Linux #100
Conversation
|
There you go! This is now running the CI on a PR |
|
OK re-pushed to add ubuntu also. Lets see! |
To a be a jerk, it probably was going to work anyway, as you were no longer a first time contributor! But you are right, pull_request was removed here, maybe due to some annoyance with it firing twice with push sometimes?
letsgooooo, going for gold!!! |
|
yeah lemme try a bit! |
|
i think that warning/error was mentioned here: #93 (comment) I thiiiink related to the precompiled binary asset stuff — it might need a bit of cleanup, but lol, surprise it's managed by copy_cmake_assets.rb |
|
OK looks like that will work. let me squash it and rewrite the comment. |
|
OK this is ready! |
|
Oooh actually hold on a second. |
|
So the precompiled thing. You are treating them as part of your main module whereas juce cmake usually makes them a separate library it compiles itself (with different flags). So it ejects code which doesn't work with error and standard juce warnings. That's OK though. You can wrap the inclusion of the CPP in a suppress-that-error GCC block I think and have a change to do that Add Lets see! |
ci.yml runs on PR and ci turns on ubuntu
Adjust the code to compile with Werror on linux
1. Remove a shadow edgeGap
2 .For the binary assets created externally by projucer,
supress the redundant-decls warning that code has and
ignores when compiled externally
Closes sudara#93
|
OK now this is really really good to go! :) |
baconpaul
changed the title
Closes #93
Lets see if this works!