Skip to content

Commit

Permalink
Troubleshoot Windows pdb issue
Browse files Browse the repository at this point in the history
  • Loading branch information
sudara committed Jul 31, 2024
1 parent 9c7cf59 commit 20a9b60
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
fail-fast: false
matrix:
app: [ member_enabled, member_disabled, unique_ptr_enabled, unique_ptr_disabled ]
os: [ macos-14, windows-2022, ubuntu-latest ]
os: [ windows-2022]
juce: [ JUCE7, JUCE8 ]

steps:
Expand All @@ -44,6 +44,8 @@ jobs:

- name: Use dev command prompt (Windows)
uses: ilammy/msvc-dev-cmd@v1
with:
sdk: 10.0.22621.0

- name: Install Ninja (Windows)
if: runner.os == 'Windows'
Expand Down
7 changes: 0 additions & 7 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,6 @@ if (MelatoninInspector_IS_TOP_LEVEL)
JUCE_WEB_BROWSER=0
)

# https://learn.microsoft.com/en-us/cpp/build/reference/mp-build-with-multiple-processes
# Needed for ninja to be happy in CI
# Hacky, ideally would be add_compile_options, but that didn't work
if (MSVC)
set(CMAKE_CXX_FLAGS "${CMAKE_C_FLAGS} /MP")
endif ()

set_target_properties("${TARGET_NAME}" PROPERTIES COMPILE_WARNING_AS_ERROR ON)

endif ()
Expand Down

0 comments on commit 20a9b60

Please sign in to comment.