-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docs #9
fix: docs #9
Conversation
example/script/src/main.rs
Outdated
let (pk, _vk) = client.setup(ELF); | ||
let (pk, vk) = client.setup(ELF); | ||
|
||
println!("vkey bytes {:?}", sp1_sdk::HashableKey::bytes32(&vk)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "Verification Key: "
//! This crate contains utilities for verifying SP1 Groth16 proofs on Solana. | ||
//! | ||
//! # Example | ||
//! ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to have the tag like ```rust on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to run as a doctest, no, since it's in a rust file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, but looks way cleaner! LGTM
Can you add a PR description?
vk.bytes32()
outputs.