feat: migrate OPSuccinctL2OutputOracle to OptimismPortalV2

[leruaa]

Adding OPSuccinctDisputeGame and OPSuccinctDisputeGameFactory contracts to integrate OPSuccinctL2OutputOracle to OptimismPortalV2.

OPSuccinctDisputeGame implements IDisputeGame and is a thin wrapper around OPSuccinctL2OutputOracle. It also implements CWIA and is cloned each time a new game is created. I didn't implement IDisputeGame on OPSuccinctL2OutputOracle as it doesn't make sense to clone it each time and is more expensive.

The proposer has been updated to call OPSuccinctDisputeGameFactory.create() each time a new outputRoot is proposed, if DGF_ADDRESS is set.

[github-actions]

Metric	Value
Batch Start	22,562,730
Batch End	22,562,735
Witness Generation (seconds)	56
Execution Duration (seconds)	52
Total Instruction Count	1,839,631,488
Oracle Verify Cycles	388,982,235
Derivation Cycles	940,269,761
Block Execution Cycles	358,636,753
Blob Verification Cycles	158,501,739
Total SP1 Gas	0
Number of Blocks	6
Number of Transactions	71
Ethereum Gas Used	16,803,953
Cycles per Block	306,605,248
Cycles per Transaction	25,910,302
Transactions per Block	11
Gas Used per Block	2,800,658
Gas Used per Transaction	236,675
BN Pair Cycles	0
BN Add Cycles	0
BN Mul Cycles	0
KZG Eval Cycles	0
EC Recover Cycles	1,416,133
P256 Verify Cycles	0

[ratankaliani]

Does this still need to be added?

[leruaa]

I set it to GameTypes.CANNON for now, and I discussed with OP Labs, they aren't opposed to adding a new GameTypes.OP_SUCCINCT

[ratankaliani]

What is the use of GAME_TYPE? To see the security model? When would GameTypes.OP_SUCCINCT be upstreamed?

[leruaa]

GameTypes are used in DisputeGameFactory to store multiple games in a mapping, with the game type as key.

We don't have a clear view on when GameTypes.OP_SUCCINCT will be upstreamed, but if for instance we add:

GameType internal constant OP_SUCCINCT = GameType.wrap(3);

here, we could temporary do:

return GameType.wrap(3);

[ratankaliani]

Sounds good, just add a comment that GameType.wrap(3) will eventually be upstreamed to be OP Succinct. Add a TODO that this GameType needs to be changed in the future, and link to the corresponding Optimism contracts PR.

[ratankaliani]

impl IDisputeGame for OPSuccinctL2OutputOracle
Additionals notes:
Initializable on OPSuccinctL2OutputOracle clashes with IInitializable on IDisputeGame (they both define initialize()), so I renamed OPSuccinctL2OutputOracle::initialize() to initializeParams()

I don't see an update to OPSuccinctL2OutputOracle? Did you incorporate that in this PR? You should make sure that you update the scripts if so.

Can you also add a new folder inside of the book/ for experimental/beta features and document how users can use the OptimismPortalV2 features. I'm planning to go through the docs and repo later this week. It's important that this feature/deployment for it is documented well.

[ratankaliani]

LGTM, once the documentation nits + DGF contract link are added