Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add two frequently asked questions to the FAQ #719

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

westonpace
Copy link
Member

These two questions come up often on Slack / other channels and I felt it was time to update the FAQ.

EpsilonPrime
EpsilonPrime previously approved these changes Oct 3, 2024
Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no approve vehemently button or I would have pressed that.

The only other name I know about is the subquery alias (located next to output_names in the RelCommon Hint).

vbarua
vbarua previously approved these changes Oct 3, 2024
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should help a bunch ✨

mbrobbel
mbrobbel previously approved these changes Oct 3, 2024
Copy link
Contributor

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor copy-editing notes.

site/docs/faq.md Outdated Show resolved Hide resolved
site/docs/faq.md Outdated Show resolved Hide resolved
site/docs/faq.md Outdated Show resolved Hide resolved
site/docs/faq.md Outdated Show resolved Hide resolved
@westonpace westonpace dismissed stale reviews from mbrobbel, vbarua, and EpsilonPrime via f9e20a2 October 4, 2024 11:24
@westonpace
Copy link
Member Author

Thanks for the cleanup @amoeba

@westonpace westonpace merged commit dc2ff4a into substrait-io:main Oct 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants