feat: add CreateMode for CTAS in WriteRel #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scgkiran
requested review from
jacques-n,
cpcloud,
westonpace,
EpsilonPrime and
vbarua
as code owners
EpsilonPrime
reviewed
Oct 1, 2024
scgkiran
force-pushed
the
SD-8295-ctas-option
branch
from
43838e3
to
0997d85
Compare
EpsilonPrime
approved these changes
Nov 5, 2024
EpsilonPrime
approved these changes
Nov 5, 2024
|
@anshuldata , you merged another spec change without at least two approvals. Remember, we need at least two SMC approvals for any spec change |
|
I am really sorry for this goof up again. @scgkiran write access wasn’t working he asked me to merge after approval. I forgot again that two approvals are required for this since its a feature. I will be extra extra careful going forward. |
Its my bad, I missed this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.