Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance VirtualTable to have expression as value #711

Merged
merged 4 commits into from
Oct 7, 2024
Merged

feat: enhance VirtualTable to have expression as value #711

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
19996a8
feat: add VirtualExpressionTable definition and use it in ReadRel
anshuldata Sep 26, 2024
b2e3d6b
Update to Doc to indicate VirtualExpressionTable values are not depen…
anshuldata Sep 30, 2024
5938f28
add virtual table values to also take expression and mark existing li…
anshuldata Oct 3, 2024
e8b85dd
address review comments
anshuldata Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion proto/substrait/algebra.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ message ReadRel {

// A table composed of literals.
anshuldata marked this conversation as resolved.
Show resolved Hide resolved
message VirtualTable {
repeated Expression.Literal.Struct values = 1;
repeated Expression.Literal.Struct values = 1 [deprecated = true];
repeated Expression expression_values = 2;
anshuldata marked this conversation as resolved.
Show resolved Hide resolved
}

// A stub type that can be used to extend/introduce new table types outside
Expand Down
5 changes: 4 additions & 1 deletion site/docs/relations/logical_relations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,15 @@ Read definition types (like the rest of the features in Substrait) are built by
#### Virtual Table

A virtual table is a table whose contents are embedded in the plan itself. The table data
is encoded as records consisting of literal values.
is encoded as records consisting of literal values or an expression that can be resolved without referencing any input data.
anshuldata marked this conversation as resolved.
Show resolved Hide resolved
For example, a literal, a function call involving literals, or any other expression that does
not require input.

| Property | Description | Required |
| -------- | ----------- | -------- |
| Data | Required | Required |


#### Named Table

A named table is a reference to data defined elsewhere. For example, there may be a catalog
Expand Down
Loading