Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ALL/DISTINCT modifier for all set operation types #708

Merged
merged 9 commits into from
Sep 27, 2024
8 changes: 8 additions & 0 deletions proto/substrait/algebra.proto
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,7 @@
// inputs. There must be at least two inputs.
repeated Rel inputs = 2;
SetOp op = 3;
SetMode mode = 4;
substrait.extensions.AdvancedExtension advanced_extension = 10;

enum SetOp {
Expand All @@ -338,6 +339,13 @@
SET_OP_INTERSECTION_MULTISET = 4;
SET_OP_UNION_DISTINCT = 5;
SET_OP_UNION_ALL = 6;
vbarua marked this conversation as resolved.
Show resolved Hide resolved
SET_OP_UNION = 7;
}

enum SetMode {
SET_OP_MODE_UNSPECIFIED = 0;

Check failure on line 346 in proto/substrait/algebra.proto

View workflow job for this annotation

GitHub Actions / Check Protobuf

Enum value name "SET_OP_MODE_UNSPECIFIED" should be prefixed with "SET_MODE_".
SET_OP_MODE_DISTINCT = 1;

Check failure on line 347 in proto/substrait/algebra.proto

View workflow job for this annotation

GitHub Actions / Check Protobuf

Enum value name "SET_OP_MODE_DISTINCT" should be prefixed with "SET_MODE_".
SET_OP_MODE_ALL = 2;

Check failure on line 348 in proto/substrait/algebra.proto

View workflow job for this annotation

GitHub Actions / Check Protobuf

Enum value name "SET_OP_MODE_ALL" should be prefixed with "SET_MODE_".
}
}

Expand Down
Loading