feat: add 'first' function #697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andrew-coleman <[email protected]>
andrew-coleman
requested review from
jacques-n,
cpcloud,
westonpace,
EpsilonPrime and
vbarua
as code owners
| @@ -40,3 +40,13 @@ aggregate_functions: | |||
| decomposable: MANY | |||
| intermediate: any1? | |||
| return: any1? | |||
| - name: "first" | |||
| description: First of a set of values. | |||
There was a problem hiding this comment.
Probably returns null if given an empty set.
| @@ -40,3 +40,13 @@ aggregate_functions: | |||
| decomposable: MANY | |||
| intermediate: any1? | |||
| return: any1? | |||
| - name: "first" | |||
| description: First of a set of values. | |||
There was a problem hiding this comment.
Additional caveat: Assumes the input is ordered. If the input is not ordered then the result is undefined.
|
FWIW, we had some discussion around this earlier, and then I concluded to just map first into any_value since in Spark they're the same anyways. That said I'm def fine with having it 🤷 |
Thanks, that worked for me, so I'm happy to close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
firstto the set of generic aggregate functions.This is required to support queries containing
distinctaggregations that get rewritten by the Spark catalyst query optimiser to containExpandrelations andfirstfunction calls.This PR, together with #696 will allow the implementation of the
Expandrelation insubstrait-java, improving the test pass rate of the TPC-DS suite in thesparkmodule.