feat: define mark join #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EpsilonPrime
requested review from
jacques-n,
cpcloud,
westonpace and
vbarua
as code owners
westonpace
requested changes
Aug 14, 2024
Co-authored-by: Weston Pace <[email protected]>
westonpace
previously approved these changes
Aug 19, 2024
jacques-n
reviewed
Aug 20, 2024
There was a problem hiding this comment.
A minor request to be super clear on output column types and ordering.
It doesn't necessarily need to be resolved here but we should really update the text of join operations to better clarify their output column ordering and types. The current text reads:
Direct Output Order: The emit order of the left input followed by the emit order of the right input.
That is no longer true with many of these join types.
Co-authored-by: Jacques Nadeau <[email protected]>
Co-authored-by: Jacques Nadeau <[email protected]>
jacques-n
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines the Mark Join used by a number of engines in query rewrites.