Skip to content

Commit

Permalink
fix: correct format for nullable interval_day parameters (#687)
Browse files Browse the repository at this point in the history
Fixes a bug in `functions_datetime.yaml` that makes it un-parseable by
substrait-java, introduced in #679. The `?` for nullability must come
before the parameters:
https://substrait.io/types/type_parsing/#type-syntax-parsing
  • Loading branch information
Blizzara authored Aug 21, 2024
1 parent bc1b93f commit 8ae1084
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions extensions/functions_datetime.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1047,8 +1047,8 @@ aggregate_functions:
value: interval_day<P>
nullability: DECLARED_OUTPUT
decomposable: MANY
intermediate: interval_day<P>?
return: interval_day<P>?
intermediate: interval_day?<P>
return: interval_day?<P>
- args:
- name: x
value: interval_year
Expand Down Expand Up @@ -1099,8 +1099,8 @@ aggregate_functions:
value: interval_day<P>
nullability: DECLARED_OUTPUT
decomposable: MANY
intermediate: interval_day<P>?
return: interval_day<P>?
intermediate: interval_day?<P>
return: interval_day?<P>
- args:
- name: x
value: interval_year
Expand Down

0 comments on commit 8ae1084

Please sign in to comment.