Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parser to parse test files and load testcases #69

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

scgkiran
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 75.66628% with 210 lines in your changes missing coverage. Please review.

Project coverage is 58.28%. Comparing base (833624e) to head (808dfb5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
testcases/parser/visitor.go 73.49% 130 Missing and 33 partials ⚠️
literal/utils.go 89.15% 12 Missing and 6 partials ⚠️
types/parser/util/error_listener.go 48.14% 13 Missing and 1 partial ⚠️
testcases/parser/nodes.go 57.14% 4 Missing and 2 partials ⚠️
types/parser/visitor.go 0.00% 6 Missing ⚠️
testcases/parser/parse.go 90.90% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   56.56%   58.28%   +1.71%     
==========================================
  Files          38       43       +5     
  Lines        8268     9130     +862     
==========================================
+ Hits         4677     5321     +644     
- Misses       3392     3565     +173     
- Partials      199      244      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a large number of positive paths in visitor.go without test coverage.

literal/utils.go Outdated Show resolved Hide resolved
literal/utils_test.go Show resolved Hide resolved
testcases/parser/baseparser/functestcaseparser_listener.go Outdated Show resolved Hide resolved
literal/utils.go Show resolved Hide resolved
@scgkiran
Copy link
Contributor Author

There are a large number of positive paths in visitor.go without test coverage.

Fixed most of them. Rest of them need a grammar change, I missed few literal types for test cases.

@scgkiran scgkiran marked this pull request as ready for review November 14, 2024 14:26
@scgkiran
Copy link
Contributor Author

I will raise another PR to take care of the pending grammar changes in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants