Skip to content

Commit

Permalink
Stop manually deleting pods
Browse files Browse the repository at this point in the history
When joining a cluster, subctl deletes any Submariner CR when it
starts, which stops all the Submariner-related pods (apart from the
operator). It is thus not useful to manually delete the pods. What's
more, we want to test the startup behaviour with existing pods in
place, if any; manually deleting them could hide issues.

Signed-off-by: Stephen Kitt <[email protected]>
  • Loading branch information
skitt authored and mkolesnik committed Dec 14, 2020
1 parent bf4401e commit 1aea0d6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion scripts/shared/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import_image quay.io/submariner/submariner-route-agent ${image_tag}
load_deploytool $deploytool
deploytool_prereqs

run_subm_clusters prepare_cluster "$SUBM_NS"
run_subm_clusters prepare_cluster

with_context $broker setup_broker
install_subm_all_clusters
Expand Down
7 changes: 0 additions & 7 deletions scripts/shared/lib/deploy_funcs
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,7 @@ function del_subm_gateway_label() {
}

function prepare_cluster() {
local namespace=$1
[[ ${cluster_subm[$cluster]} = "true" ]] || return 0
for app in submariner-engine submariner-routeagent submariner-globalnet; do
if kubectl wait --for=condition=Ready pods -l "app=$app" -n "$namespace" --timeout="${timeout}" > /dev/null 2>&1; then
echo "Removing $app pods..."
kubectl delete pods -n "$namespace" -l "app=$app"
fi
done
add_subm_gateway_label
}

Expand Down

0 comments on commit 1aea0d6

Please sign in to comment.