Advancing 0.19.0-rc3 release to status: admiral #1109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
requested review from
aswinsuryan,
dfarrell07,
maayanf24,
mkolesnik,
Oats87,
skitt,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 I see this PR is using the local branch workflow, ignoring it on my side, have fun! |
Jaanki
commented
Oct 18, 2024
There was a problem hiding this comment.
This is wrong SHA. The correct one should be 8a5ecb962986f6d57d43845e8a3bea8b172f508f as per https://github.com/submariner-io/admiral/commits/release-0.19/
vthapar
approved these changes
Oct 18, 2024
|
Missed your comment. Are you pushing followup commit with correct sha? |
tpantelis
approved these changes
Oct 18, 2024
|
This PR/issue depends on:
|
vthapar
requested changes
Oct 18, 2024
| components: | ||
| shipyard: 35f3468294128ce32bec0d775ff3131127dd9076 | ||
| admiral: 99b5ac397a07a2256f4fa88ef99a5e65f744e149 |
There was a problem hiding this comment.
Suggested change
| admiral: 99b5ac397a07a2256f4fa88ef99a5e65f744e149 | |
| admiral: 8a5ecb962986f6d57d43845e8a3bea8b172f508f |
|
Pushing a new PR with correct SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components:
Depends on Update Submariner dependencies to v0.19.0-rc3 admiral#1009