Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - Vite Plugin Id Matching #3

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

woodbrettm
Copy link
Member

Fix issues with matching source module and stylesheet module Ids in tools like Nuxt, as well as styles being dropped in some prod builds.

* Change stylesheet ID from using virtual prefix to .compiled.css
* Change stylesheet ID matching from checking prefix to checking suffix
* Fix issue with styles being dropped in prod build with Nuxt
Copy link

changeset-bot bot commented Jan 23, 2024

🦋 Changeset detected

Latest commit: 2c8c803

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stylebucket/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@woodbrettm woodbrettm self-assigned this Jan 23, 2024
Copy link

socket-security bot commented Jan 23, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +648 154 MB danielroe
npm/[email protected] environment Transitive: eval, filesystem, unsafe +25 47.9 MB posva
npm/[email protected] environment, eval Transitive: filesystem, unsafe +23 47 MB yyx990803

View full report↗︎

Copy link

socket-security bot commented Jan 23, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@nuxt/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@woodbrettm
Copy link
Member Author

@SocketSecurity ignore npm/@nuxt/[email protected]

@woodbrettm woodbrettm merged commit 6938081 into main Jan 24, 2024
6 checks passed
@woodbrettm woodbrettm deleted the bugfix/vite-plugin-id-matching branch January 24, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant