Updates to use the latest versions of sparqljs and n3. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates rdfjs libs to modules versions and rdf-string. As a consequence, the following changes were made: - The change focuses on changing over the legacy sparqljs types to the newer ones and tries not to make other possible changes at this stage. - Lib updated to module format - replaced mocha with vitest (due to isses with mocha and esm) - Generally changed indexing to Variables and Terms over strings - Adds convenience toArray to pipelines
Error was in test code, not in the library itself. Adds tests cases provided by @JuniperChicago.
and removes some resolved comments
tslint is deprecated. This commit replaces tslint with eslint. But does not include any changes to the code.
mainly let -> const
Extraacts utils namespaces to separate modules. Adds missing typings where possible. Removes this to self aliasing.
leaves the test to run in lts versions 16, 18 and 20
not supported by vitest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates rdfjs libs to modules versions and rdf-string.
As a consequence, the following changes were made:
The change focuses on changing over the legacy sparqljs types to the newer ones and tries not to make other possible changes at this stage.
Lib updated to module format
replaced mocha with vitest (due to isses with mocha and esm)
Generally changed indexing to Variables and Terms over strings
Adds convenience toArray to pipelines
See also Callidon#85
Continuing here to make progress may be able to merge back to upstream later of release separately