Suggestions #56
Suggestions #56
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
| @@ -141,7 +174,7 @@ _beforeEach.givenUser = function(attrs, optionalHandler) { | |||
| _beforeEach.givenUserWithRole = function (attrs, role, optionalHandler) { | |||
| _beforeEach.givenUser(attrs, function (done) { | |||
| var test = this; | |||
| test.app.models.Role.findOrCreate({name: role}, function (err, result) { | |||
| test.app.models[this.roleModel].findOrCreate({name: role}, function (err, result) { | |||
There was a problem hiding this comment.
This should fall back on app.models.Role for backwards compatibility.
|
Can you sign the CLA? |
|
If I only knew where to find it? |
|
@AlmaasAre can you also sign the CLA? https://cla.strongloop.com/agreements/strongloop/loopback-testing |
|
Done! |
|
Is there any idea on how soon this can be merged ? I'm currently making tests and this has been one of the drawbacks I've found. |
|
@ainesophaur in the mean time you are aware you can install it before it is merged? |
|
Yes that's the current solution I'm doing. I was just hoping to not have to
|
No description provided.