Link v3: Re-add PayWithLinkViewController #4165
Draft
+3,217
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build increased size, 5 builds decreased size
StripeSize 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| Localizable.strings | ⬇️ -4.1 kB |
| 📝 StripePaymentsUI.CardBrandView.init(showCVC,centerHorizontally) | ⬆️ 1.8 kB |
| 🗑 StripePaymentsUI.CardBrandView.init(showCVC) | ⬇️ -1.7 kB |
| 🗑 StripeCore.Locale.toLanguageTag | ⬇️ -1.4 kB |
| 🗑 StripeUICore.AddressSpecProvider.AddressSpecProvider | ⬇️ -896 B |
View Treemap
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 8.5 kB (-0.56%)
Total download size change: ⬇️ 2.0 kB (-0.46%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 🗑 StripeCore.Locale.toLanguageTag | ⬇️ -1.4 kB |
| StripeCore.ElementsSessionContext.value witness | ⬇️ -604 B |
| 🗑 StripeCore.ElementsSessionContext.IntentID | ⬇️ -577 B |
| Other | ⬇️ -5.9 kB |
View Treemap
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 8.5 kB (-0.2%)
Total download size change: ⬇️ 4.4 kB (-0.34%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 🗑 StripeFinancialConnections.FinancialConnectionsAPIClient.linkAcco... | ⬇️ -1.7 kB |
| 🗑 StripeCore.Locale.toLanguageTag | ⬇️ -1.4 kB |
| 📝 StripeFinancialConnections.FinancialConnectionsAPIClient.linkAcco... | ⬆️ 956 B |
| 🗑 StripeUICore.AddressSpecProvider.AddressSpecProvider | ⬇️ -896 B |
| 🗑 StripeUICore.BSBNumberProvider.BSBNumberProvider | ⬇️ -884 B |
View Treemap
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 8.9 kB (-0.22%)
Total download size change: ⬇️ 2.7 kB (-0.23%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 🗑 StripeCore.Locale.toLanguageTag | ⬇️ -1.4 kB |
| StripeCore.ElementsSessionContext.value witness | ⬇️ -604 B |
| 🗑 StripeCore.ElementsSessionContext.IntentID | ⬇️ -577 B |
| Other | ⬇️ -6.3 kB |
View Treemap
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 10.6 kB (-0.17%)
Total download size change: ⬇️ 617 B (-0.03%)
Largest size changes
| Item | Install Size Change |
|---|---|
| Localizable.strings | ⬇️ -4.1 kB |
| 📝 StripePaymentsUI.CardBrandView.init(showCVC,centerHorizontally) | ⬆️ 1.8 kB |
| 🗑 StripePaymentsUI.CardBrandView.init(showCVC) | ⬇️ -1.7 kB |
| 🗑 StripeCore.Locale.toLanguageTag | ⬇️ -1.4 kB |
| 🗑 StripeUICore.AddressSpecProvider.AddressSpecProvider | ⬇️ -896 B |
View Treemap
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 356.1 kB (3.47%)
Total download size change: ⬆️ 140.4 kB (4.09%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 🗑 StripePaymentSheet.EmbeddedFormViewController | ⬇️ -23.1 kB |
| Code Signature | ⬆️ 8.3 kB |
| 🗑 StripePaymentSheet.CardSectionElement.init(collectName,defaultVal... | ⬇️ -8.2 kB |
| 📝 StripePaymentSheet.CardSectionElement.init(collectName,defaultVal... | ⬆️ 8.0 kB |
| 📝 StripePaymentSheet.EmbeddedPaymentMethodsView.init(initialSelecti... | ⬆️ 7.6 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
|
🚨 New dead code detected in this PR: LinkNoticeView.swift:56 warning: Initializer 'init(type:text:)' is unused
LinkPaymentMethodPicker.swift:34 warning: Parameter 'picker' is unused
LinkPaymentMethodPicker.swift:269 warning: Parameter 'animated' is unused
PayWithLinkViewController-BaseViewController.swift:93 warning: Parameter 'sender' is unused
PayWithLinkViewController-NewPaymentViewController.swift:294 warning: Parameter 'sender' is unused
PayWithLinkViewController-NewPaymentViewController.swift:320 warning: Function 'shouldOfferLinkSignup(_:)' is unused
PayWithLinkViewController-SignUpViewController.swift:217 warning: Parameter 'sender' is unused
PayWithLinkViewController-SignUpViewController.swift:245 warning: Parameter 'viewModel' is unused
PayWithLinkViewController-SignUpViewController.swift:307 warning: Parameter 'legalTermsView' is unused
PayWithLinkViewController-SignUpViewModel.swift:11 warning: Imported module 'StripeCore' is unused
PayWithLinkViewController-SignUpViewModel.swift:18 warning: Parameter 'viewModel' is unused
PayWithLinkViewController-SignUpViewModel.swift:136 warning: Property 'configuration' is assigned, but never used
PayWithLinkViewController-UpdatePaymentViewController.swift:26 warning: Property 'intent' is assigned, but never used
PayWithLinkViewController-WalletViewController.swift:259 warning: Parameter 'intent' is unused
PayWithLinkViewController-WalletViewController.swift:295 warning: Parameter 'sender' is unused
PayWithLinkViewController-WalletViewController.swift:401 warning: Parameter 'viewModel' is unused
PayWithLinkViewController-WalletViewController.swift:415 warning: Parameter 'picker' is unused
PayWithLinkViewController-WalletViewController.swift:537 warning: Parameter 'mandateView' is unused
PayWithLinkViewController-WalletViewModel.swift:14 warning: Parameter 'viewModel' is unused
PayWithLinkViewController.swift:13 warning: Imported module 'StripeUICore' is unused
PayWithLinkViewController.swift:280 warning: Parameter 'completion' is unused
LinkInstantDebitMandateView.swift:19 warning: Parameter 'mandateView' is unused
PayWithLinkController-New.swift:17 warning: Class 'PayWithNativeLinkController' is unused
PayWithLinkController-New.swift:72 warning: Extension 'PayWithNativeLinkController' is unused
PaymentSheet+PaymentMethodAvailability.swift:63 warning: Property 'supportedLinkPaymentMethods' is assigned, but never used
PaymentSheetConfiguration.swift:191 warning: Property 'linkPaymentMethodsOnly' is assigned, but never usedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
davidme-stripe
force-pushed
the
relink/pwlvc
branch
from
cf726ee
to
6529349
Compare
StripePaymentSheet- public var paymentMethodLayout: StripePaymentSheet.PaymentSheet.PaymentMethodLayout
- }
- public enum PaymentMethodLayout {
- case horizontal
- case vertical
- case automatic
- public static func == (a: StripePaymentSheet.PaymentSheet.PaymentMethodLayout, b: StripePaymentSheet.PaymentSheet.PaymentMethodLayout) -> Swift.Bool
- public func hash(into hasher: inout Swift.Hasher)
- public var hashValue: Swift.Int {
- get
- }If you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
davidme-stripe
force-pushed
the
relink/pwlvc
branch
from
6529349
to
35541e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-add the Pay With Link View Controller.
Motivation
Link v3
Testing
Resurrected existing VC tests
Changelog
None