Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Instant Debits with deferred intents #4154

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

Changelog

Copy link

🚨 New dead code detected in this PR:

FinancialConnectionsPaymentDetails.swift:11 warning: Protocol 'PaymentMethodIDProvider' is redundant as it's never used as an existential type
FinancialConnectionsPaymentDetails.swift:33 warning: Protocol 'PaymentMethodIDProvider' conformance is redundant
PaymentMethodFormViewController.swift:203 warning: Enum case 'instantDebitsDeferredIntentNotSupported' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

@tillh-stripe tillh-stripe force-pushed the tillh/instant-debits-deferred-intent branch 2 times, most recently from 758f315 to da08eb6 Compare October 17, 2024 20:24
Copy link

github-actions bot commented Oct 17, 2024

⚠️ Public API changes detected:

StripePaymentSheet

+ case invalidLinkBankPaymentMethod

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

@tillh-stripe tillh-stripe force-pushed the tillh/instant-debits-deferred-intent branch from da08eb6 to 6d2214a Compare October 17, 2024 22:14
@tillh-stripe
Copy link
Collaborator Author

Added the modifies public API label to account for the new PaymentSheetError case. Let me know if that’s not fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant