Downgrade release action ubuntu version #1294
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etsai2-stripe
approved these changes
Jan 22, 2025
vcheung-stripe
deleted the
vcheung-downgrade-release-action-ubuntu-version
branch
|
Confirmed this works: https://github.com/stripe/stripe-cli/actions/runs/12915497879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @
cc @stripe/developer-products
Summary
The latest release action fails when trying to upload to artificatory: https://github.com/stripe/stripe-cli/actions/runs/12899742651. Checking the logs reveals the publish-to-artificatory.sh script never made any request to artifcatory.
There aren't any related changes in our repo between this release (v1.23.5) and the last successful one (v1.23.3). The only difference I could find between these two was that ubuntu-latest has been updated from 22.04 to 24.04, which I confirmed in the GitHub actions logs. This pins it to the older version to confirm if this is the cause of the failure.