Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-git package to v5.13.0, update linter #1287

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

vcheung-stripe
Copy link
Collaborator

Reviewers

r? @
cc @stripe/developer-products

Summary

This updates the go-git package to v5.13.0. That package requires go v1.22.0, which makes some of the linters fail or stop working, so we update those too.

@vcheung-stripe vcheung-stripe requested a review from a team as a code owner January 22, 2025 00:25
Copy link
Collaborator

@kwu-stripe kwu-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to reenable revive but not varcheck or deadcode?

@kwu-stripe
Copy link
Collaborator

varcheck and deadcode are abandoned and won’t report anything

@vcheung-stripe vcheung-stripe merged commit f1e69c5 into master Jan 22, 2025
12 checks passed
@vcheung-stripe vcheung-stripe deleted the vcheung-golangci-lint-1.63.4 branch January 22, 2025 00:42
vcheung-stripe added a commit that referenced this pull request Jan 22, 2025
vcheung-stripe added a commit that referenced this pull request Jan 22, 2025
* Revert "update go version for goreleaser to 1.22.0 (#1288)"

This reverts commit 0eab402.

* Revert "update deps, linter (#1287)"

This reverts commit f1e69c5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants