update linter

stripe · Jan 22, 2025 · 186a173 · 186a173
1 parent 1c62d05
commit 186a173
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 5 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -37,7 +37,7 @@ jobs:
     - name: golangci-lint
       uses: golangci/golangci-lint-action@v6
       with:
-        version: v1.48
+        version: v1.63.4
     - name: Run Tests
       run: make ci
       shell: bash
diff --git a/.golangci.yml b/.golangci.yml
@@ -5,7 +5,6 @@ linters:
   disable-all: true
   enable:
     - bodyclose
-    - deadcode
     - depguard
     - dogsled
     - dupl
@@ -20,21 +19,35 @@ linters:
     - ineffassign
     - misspell
     - nakedret
-    - revive
+    # - revive -- TODO: reenable after fixing errors
     # - rowserrcheck -- disabled because of https://github.com/golangci/golangci-lint/issues/2649
     - staticcheck
     # - structcheck -- disabled because of https://github.com/golangci/golangci-lint/issues/2649
     - typecheck
     - unconvert
     - unused
-    - varcheck
     - whitespace
 
 linters-settings:
+  depguard:
+    rules:
+      main:
+        list-mode: lax
+        allow:
+          - $all
+        deny: []
   goimports:
     local-prefixes: github.com/stripe/stripe-cli
+  govet:
+    disable:
+      - printf
   misspell:
     locale: US
+  staticcheck:
+    checks:
+      - all
+      - -SA1006
+      - -SA1019
 
 issues:
   exclude-rules:

diff --git a/Makefile b/Makefile
@@ -6,7 +6,7 @@ PROTOC_FAILURE_MESSAGE="\nFailed to compile protobuf files: protoc exited with c
 export GO111MODULE := on
 export GOBIN := $(shell pwd)/bin
 export PATH := $(GOBIN):$(PATH)
-export GOLANGCI_LINT_VERSION := v1.48.0
+export GOLANGCI_LINT_VERSION := v1.63.4
 
 # Install all the build and lint dependencies
 setup: