Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BI references from StripeColorUtilsTest #9491

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

amk-stripe
Copy link
Collaborator

Summary

Remove BI references from StripeColorUtilsTest

Motivation

Remove references to BI before it is deleted

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Oct 21, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
      dex │   4.1 MiB │   4.1 MiB │ +18 B │   8.9 MiB │   8.9 MiB │ +16 B 
     arsc │   2.3 MiB │   2.3 MiB │   0 B │   2.3 MiB │   2.3 MiB │   0 B 
 manifest │   5.1 KiB │   5.1 KiB │   0 B │  25.6 KiB │  25.6 KiB │   0 B 
      res │ 933.7 KiB │ 933.7 KiB │   0 B │   1.5 MiB │   1.5 MiB │   0 B 
   native │   2.6 MiB │   2.6 MiB │   0 B │     6 MiB │     6 MiB │   0 B 
    asset │   2.9 MiB │   2.9 MiB │  -1 B │   2.9 MiB │   2.9 MiB │  -1 B 
    other │ 201.3 KiB │ 201.3 KiB │ +12 B │ 443.4 KiB │ 443.4 KiB │   0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
    total │    13 MiB │    13 MiB │ +29 B │  22.1 MiB │  22.1 MiB │ +15 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 42989 │ 42989 │ 0 (+1 -1) 
   types │ 14510 │ 14510 │ 0 (+0 -0) 
 classes │ 12096 │ 12096 │ 0 (+0 -0) 
 methods │ 62460 │ 62460 │ 0 (+0 -0) 
  fields │ 41053 │ 41053 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6274 │ 6274 │  0
APK
    compressed    │   uncompressed    │                                           
──────────┬───────┼───────────┬───────┤                                           
 size     │ diff  │ size      │ diff  │ path                                      
──────────┼───────┼───────────┼───────┼───────────────────────────────────────────
  4.1 MiB │ +18 B │   8.9 MiB │ +16 B │ ∆ classes.dex                             
 53.7 KiB │  +7 B │ 119.2 KiB │   0 B │ ∆ META-INF/CERT.SF                        
 50.5 KiB │  +5 B │ 119.1 KiB │   0 B │ ∆ META-INF/MANIFEST.MF                    
    271 B │  -1 B │     120 B │   0 B │ ∆ META-INF/version-control-info.textproto 
  8.1 KiB │  -1 B │     8 KiB │  -1 B │ ∆ assets/dexopt/baseline.prof             
  1.2 KiB │  +1 B │   1.2 KiB │   0 B │ ∆ META-INF/CERT.RSA                       
──────────┼───────┼───────────┼───────┼───────────────────────────────────────────
  4.2 MiB │ +29 B │   9.1 MiB │ +15 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   42989 │ 42989 │ 0 (+1 -1) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"d68e2a3","r8-mode":"full","version":"8.5.35"}
  
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"608ec30","r8-mode":"full","version":"8.5.35"}

@amk-stripe amk-stripe marked this pull request as ready for review October 21, 2024 21:22
@amk-stripe amk-stripe requested review from a team as code owners October 21, 2024 21:22
@amk-stripe amk-stripe enabled auto-merge (squash) October 21, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant