Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter card brands in Google Pay #9479

Draft
wants to merge 2 commits into
base: porter/cbf-analytics
Choose a base branch
from
Draft

Filter card brands in Google Pay #9479

wants to merge 2 commits into from

Conversation

porter-stripe
Copy link
Contributor

@porter-stripe porter-stripe commented Oct 18, 2024 •
edited
Loading

Summary

  • TODO need to test on a real device

Motivation

  • Card brand filter

Testing

  • Manual
  • New unit tests

Screenshots

Before After
before screenshot after screenshot

Changelog

N/A

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed             │           uncompressed            
          ├───────────┬───────────┬───────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff      │ old       │ new       │ diff      
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
      dex │     4 MiB │     4 MiB │    -7 KiB │   8.7 MiB │   8.6 MiB │ -12.1 KiB 
     arsc │   2.3 MiB │   2.3 MiB │    +764 B │   2.3 MiB │   2.3 MiB │    +764 B 
 manifest │   5.1 KiB │   5.1 KiB │      -1 B │  25.6 KiB │  25.6 KiB │       0 B 
      res │ 933.8 KiB │ 933.8 KiB │       0 B │   1.5 MiB │   1.5 MiB │       0 B 
   native │   2.6 MiB │   2.6 MiB │       0 B │     6 MiB │     6 MiB │       0 B 
    asset │   2.9 MiB │   2.9 MiB │     -94 B │   2.9 MiB │   2.9 MiB │     -94 B 
    other │ 200.7 KiB │ 195.9 KiB │  -4.8 KiB │ 442.2 KiB │ 430.6 KiB │ -11.7 KiB 
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
    total │  12.9 MiB │  12.9 MiB │ -11.2 KiB │  21.9 MiB │  21.8 MiB │ -23.1 KiB 

 DEX     │ old   │ new   │ diff              
─────────┼───────┼───────┼───────────────────
   files │     1 │     1 │   0               
 strings │ 42478 │ 42523 │ +45 (+283 -238)   
   types │ 14264 │ 14277 │ +13 (+134 -121)   
 classes │ 11874 │ 11883 │  +9 (+88 -79)     
 methods │ 61039 │ 61087 │ +48 (+9237 -9189) 
  fields │ 40267 │ 40295 │ +28 (+5141 -5113) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  242 │  242 │  0         
 entries │ 6269 │ 6272 │ +3 (+3 -0)
APK 
      compressed      │     uncompressed      │                                                                 
──────────┬───────────┼───────────┬───────────┤                                                                 
 size     │ diff      │ size      │ diff      │ path                                                            
──────────┼───────────┼───────────┼───────────┼─────────────────────────────────────────────────────────────────
    4 MiB │    -7 KiB │   8.6 MiB │ -12.1 KiB │ ∆ classes.dex                                                   
          │  -3.7 KiB │           │  -9.9 KiB │ - META-INF/androidx/annotation/annotation/LICENSE.txt           
  2.3 MiB │    +764 B │   2.3 MiB │    +764 B │ ∆ resources.arsc                                                
          │    -624 B │           │    -1 KiB │ - META-INF/NOTICE.md                                            
          │    -206 B │           │      -6 B │ - META-INF/androidx.lifecycle_lifecycle-runtime-compose.version 
 50.1 KiB │    -200 B │ 118.2 KiB │    -346 B │ ∆ META-INF/MANIFEST.MF                                          
 53.4 KiB │    -125 B │ 118.3 KiB │    -346 B │ ∆ META-INF/CERT.SF                                              
  7.9 KiB │     -77 B │   7.8 KiB │     -77 B │ ∆ assets/dexopt/baseline.prof                                   
  1,001 B │     -17 B │     869 B │     -17 B │ ∆ assets/dexopt/baseline.profm                                  
  5.1 KiB │      -1 B │  25.6 KiB │       0 B │ ∆ AndroidManifest.xml                                           
    850 B │      +1 B │   1.8 KiB │       0 B │ ∆ res/8Q.xml                                                    
  1.2 KiB │      -1 B │   3.7 KiB │       0 B │ ∆ res/BH.xml                                                    
  1.2 KiB │      -1 B │   1.2 KiB │       0 B │ ∆ META-INF/CERT.RSA                                             
──────────┼───────────┼───────────┼───────────┼─────────────────────────────────────────────────────────────────
  6.4 MiB │ -11.2 KiB │  11.3 MiB │ -23.1 KiB │ (total)
MANIFEST 
@@ -453,3 +453,21 @@
         />
+    <service
+        android:exported="false"
+        android:name="com.google.android.datatransport.runtime.backends.TransportBackendDiscovery"
+        >
+      <meta-data
+          android:name="backend:com.google.android.datatransport.cct.CctBackendFactory"
+          android:value="cct"
+          />
+    </service>
+    <service
+        android:exported="false"
+        android:name="com.google.android.datatransport.runtime.scheduling.jobscheduling.JobInfoSchedulerService"
+        android:permission="android.permission.BIND_JOB_SERVICE"
+        />
     <receiver
+        android:exported="false"
+        android:name="com.google.android.datatransport.runtime.scheduling.jobscheduling.AlarmManagerSchedulerBroadcastReceiver"
+        />
+    <receiver
         android:directBootAware="false"
@@ -481,20 +499,2 @@
     </receiver>
-    <service
-        android:exported="false"
-        android:name="com.google.android.datatransport.runtime.backends.TransportBackendDiscovery"
-        >
-      <meta-data
-          android:name="backend:com.google.android.datatransport.cct.CctBackendFactory"
-          android:value="cct"
-          />
-    </service>
-    <service
-        android:exported="false"
-        android:name="com.google.android.datatransport.runtime.scheduling.jobscheduling.JobInfoSchedulerService"
-        android:permission="android.permission.BIND_JOB_SERVICE"
-        />
-    <receiver
-        android:exported="false"
-        android:name="com.google.android.datatransport.runtime.scheduling.jobscheduling.AlarmManagerSchedulerBroadcastReceiver"
-        />
     <meta-data
DEX 
STRINGS:

   old   │ new   │ diff            
  ───────┼───────┼─────────────────
   42478 │ 42523 │ +45 (+283 -238) 
  
  +  has been canceled.
  +  isIconified=
  +  persisted successfully.
  +  returned exception.
  + _animationInfo
  + _awaitingContainerChanges
  + _lastInViews
  + _transitionInfo
  + Could not find voice search activity
  + ENABLED_STATE_SET
  + Error closing icon stream for 
  + FILZ
  + FOCUSED_STATE_SET
  + Failed launch activity: 
  + Failed to open 
  + Icon not found: 
  + Icon resource not found: 
  + Invalid icon resource 
  + LA8/f;
  + LD0/K;
  + LE5/g;
  + LF/f;
  + LG0/j;
  + LL0/S;
  + LLLZLZLLLLZL
  + LP3/m;
  + LR1/n;
  + LR1/o;
  + LR1/p;
  + LT0/f;
  + LT8/e;
  + LT8/f;
  + LT8/g;
  + La8/W1;
  + La8/X1;
  + Landroid/app/SearchableInfo;
  + Landroid/content/pm/ComponentInfo;
  + Landroid/text/style/TextAppearanceSpan;
  + Landroid/view/TouchDelegate;
  + Landroidx/appcompat/widget/SearchView;
  + Landroidx/appcompat/widget/a;
  + Landroidx/appcompat/widget/b;
  + Landroidx/appcompat/widget/c;
  + Landroidx/appcompat/widget/d;
  + Landroidx/recyclerview/widget/N0;
  + Lb1/m1;
  + Lcom/android/volley/toolbox/j;
  + Lcom/android/volley/toolbox/k;
  + Ld2/c;
  + Lh/W;
  + Li2/c;
  + Li2/d;
  + Li2/e;
  + Li2/f;
  + Li2/g;
  + Li2/h;
  + Li2/i;
  + Li2/j;
  + Li2/k;
  + Li2/l;
  + Li2/m;
  + Li2/n;
  + Li2/o;
  + Li2/p;
  + Li2/q;
  + Li2/r;
  + Li2/s;
  + Li2/t;
  + Li2/u;
  + Li2/v;
  + Li2/w;
  + Li2/x;
  + Li2/y;
  + Ljava/lang/UnsupportedClassVersionError;
  + Lk/c;
  + Lk2/b;
  + Lk2/c;
  + Lk2/d;
  + Lk2/e;
  + Lk2/f;
  + Lk2/g;
  + Lk2/h;
  + Lk2/i;
  + Lk2/j;
  + Lk2/k;
  + Lm/o;
  + Lm2/c;
  + Lm2/d;
  + Lm2/e;
  + Lm2/f;
  + Lm2/g;
  + Lm2/h;
  + Ln/E;
  + Ln/F;
  + Lo/l1;
  + Lo/m1;
  + Lo/n1;
  + Lo/o1;
  + Lo/p1;
  + Lo/q1;
  + Lo/r1;
  + Lo/s1;
  + Lo/t1;
  + Lo/u1;
  + Lo/v1;
  + Lo/w1;
  + Lo/x1;
  + Lo/y1;
  + Lq1/j;
  + Lv2/m;
  + Lx6/u;
  + Lz5/m1;
  + More than two path segments: 
  + No authority: 
  + No path: 
  + No resource found for: 
  + REL
  + Reading app Locales : Locales read from file: androidx.appcompat.app.AppCompatDelegate.application_locales_record_file , appLocales: 
  + Reading app Locales : Locales record file not found: androidx.appcompat.app.AppCompatDelegate.application_locales_record_file
  + Resource does not exist: 
  + Search suggestions cursor at row 
  + Search suggestions cursor threw exception.
  + Search suggestions query threw an exception.
  + SearchAutoComplete
  + SearchView
  + SearchView.SavedState{
  + Single path segment is not a resource ID: 
  + Storing App Locales : Failed to persist app-locales: 
  + Storing App Locales : app-locales: 
  + SuggestionsAdapter
  + This function can only be used for API Level < 29.
  + Tiramisu
  + VLLZILLL
  + VZLLZLLLLI
  + [LA2/s;
  + [LA5/e;
  + [LG0/j;
  + [LP3/e;
  + [La1/l0;
  + [La7/M0;
  + [La7/Q0;
  + [La7/V0;
  + [La7/Z0;
  + [La7/l1;
  + [La8/V1;
  + [La8/W1;
  + [La8/y0;
  + [Landroidx/fragment/app/D;
  + [Landroidx/fragment/app/Y;
  + [Landroidx/fragment/app/d0;
  + [Landroidx/fragment/app/g0;
  + [Landroidx/recyclerview/widget/L0;
  + [Landroidx/recyclerview/widget/O;
  + [Landroidx/recyclerview/widget/Z;
  + [Landroidx/recyclerview/widget/w0;
  + [Ld0/Y;
  + [Ld0/c0;
  + [Lf2/b;
  + [Lh/E;
  + [Li2/h;
  + [Li2/s;
  + [Li2/v;
  + [Lm2/b;
  + [Ln/f;
  + [Lo/N;
  + [Lo/p1;
  + [Lo9/e;
  + [Lt0/P0;
  + [Lt0/X;
  + [Lt0/Y;
  + [Lt0/g0;
  + [Lt7/q;
  + [Lu0/E;
  + [Lz5/Z0;
  + android.intent.action.SEARCH
  + android.resource
  + android.resource://
  + android.speech.action.RECOGNIZE_SPEECH
  + android.speech.action.WEB_SEARCH
  + android.speech.extra.LANGUAGE
  + android.speech.extra.LANGUAGE_MODEL
  + android.speech.extra.MAX_RESULTS
  + android.speech.extra.PROMPT
  + android.speech.extra.RESULTS_PENDINGINTENT
  + android.speech.extra.RESULTS_PENDINGINTENT_BUNDLE
  + app_data
  + awaiter
  + calling_package
  + cancelLongPress
  + clearListSelection
  + convertResultToString
  + couldn't move cursor to position 
  + createFromStream
  + cs_disallowed_card_brand
  + deliverSelfNotifications
  + doAfterTextChanged
  + doBeforeTextChanged
  + ensureImeVisible
  + error changing cursor and caching columns
  + flattenToShortString
  + free_form
  + getColumnIndexOrThrow
  + getDefaultActivityIcon
  + getDropDownAnchor
  + getHintId
  + getIconResource
  + getImeOptions
  + getListSelection
  + getPreferredHeight
  + getPreferredWidth
  + getQueryHint
  + getSearchActivity
  + getSu
...✂
ARSC 
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6269 │ 6272 │ +3 (+3 -0) 
  + dimen/abc_search_view_preferred_height
  + dimen/abc_search_view_preferred_width
  + string/stripe_disallowed_card_brand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
card brand filtering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@porter-stripe