-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass link_mode
to LAS creation
#9454
Open
tillh-stripe
wants to merge
4
commits into
master
Choose a base branch
from
tillh/pass-link-mode-to-las-creation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffuse output:
APK
DEX
|
tillh-stripe
force-pushed
the
tillh/pass-link-mode-to-las-creation
branch
from
October 16, 2024 16:47
18ee455
to
d9f9513
Compare
tillh-stripe
force-pushed
the
tillh/pass-link-mode-to-las-creation
branch
from
October 16, 2024 17:30
d9f9513
to
4f72957
Compare
tillh-stripe
requested review from
toluo-stripe,
carlosmuvi-stripe and
jaynewstrom-stripe
October 16, 2024 22:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a
link_mode
field to the LAS creation request. If Link is not enabled, we sendLINK_DISABLED
just like Web does.(cc @selinafeng-stripe)
Motivation
BANKCON-15654
Testing
Screenshots
Changelog