Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass link_mode to LAS creation #9454

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Oct 16, 2024

Summary

This pull request adds a link_mode field to the LAS creation request. If Link is not enabled, we send LINK_DISABLED just like Web does.

(cc @selinafeng-stripe)

Motivation

BANKCON-15654

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed          
          ├───────────┬───────────┬──────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff   
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼────────
      dex │     4 MiB │     4 MiB │ +1.1 KiB │   8.7 MiB │   8.7 MiB │ +2 KiB 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │   2.3 MiB │   2.3 MiB │    0 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │  25.6 KiB │  25.6 KiB │    0 B 
      res │ 933.8 KiB │ 933.8 KiB │      0 B │   1.5 MiB │   1.5 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │    0 B 
    asset │   2.9 MiB │   2.9 MiB │    -13 B │   2.9 MiB │   2.9 MiB │  -13 B 
    other │ 200.7 KiB │ 200.7 KiB │     -6 B │ 442.2 KiB │ 442.2 KiB │    0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼────────
    total │  12.9 MiB │  12.9 MiB │ +1.1 KiB │  21.9 MiB │  21.9 MiB │ +2 KiB 

 DEX     │ old   │ new   │ diff             
─────────┼───────┼───────┼──────────────────
   files │     1 │     1 │   0              
 strings │ 42478 │ 42484 │  +6 (+19 -13)    
   types │ 14264 │ 14268 │  +4 (+16 -12)    
 classes │ 11874 │ 11877 │  +3 (+4 -1)      
 methods │ 61039 │ 61051 │ +12 (+1005 -993) 
  fields │ 40267 │ 40274 │  +7 (+303 -296)  

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6269 │ 6269 │  0
APK
     compressed      │    uncompressed    │                                           
──────────┬──────────┼───────────┬────────┤                                           
 size     │ diff     │ size      │ diff   │ path                                      
──────────┼──────────┼───────────┼────────┼───────────────────────────────────────────
    4 MiB │ +1.1 KiB │   8.7 MiB │ +2 KiB │ ∆ classes.dex                             
    8 KiB │    -14 B │   7.9 KiB │  -14 B │ ∆ assets/dexopt/baseline.prof             
 53.5 KiB │     -4 B │ 118.6 KiB │    0 B │ ∆ META-INF/CERT.SF                        
    270 B │     -1 B │     120 B │    0 B │ ∆ META-INF/version-control-info.textproto 
  1,019 B │     +1 B │     887 B │   +1 B │ ∆ assets/dexopt/baseline.profm            
  1.2 KiB │     -1 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────────┼───────────┼────────┼───────────────────────────────────────────
    4 MiB │ +1.1 KiB │   8.8 MiB │ +2 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   42478 │ 42484 │ +6 (+19 -13) 
  
  + LINK_DISABLED
  + Lcom/android/volley/toolbox/j;
  + Lf7/g;
  + Lo7/c;
  + Ls2/K;
  + USBankAccountInternal(name=
  + [Ld0/d0;
  + [Lf7/c;
  + [Ln6/L;
  + [Ln6/s2;
  + [Ln8/Q;
  + [Ls2/J;
  + [Ls2/l;
  + [Ls2/u;
  + [Ls8/A;
  + [Ls8/C;
  + [Ls8/y;
  + [Lx3/n;
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"16b564c","r8-mode":"full","version":"8.5.35"}
  
  - Ls8/P;
  - [Ld0/W;
  - [Ln6/K;
  - [Ln6/r2;
  - [Ln8/P;
  - [Ls2/I;
  - [Ls2/k;
  - [Ls2/t;
  - [Ls8/B;
  - [Ls8/G;
  - [Ls8/z;
  - [Lx3/m;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"bde934a","r8-mode":"full","version":"8.5.35"}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   14264 │ 14268 │ +4 (+16 -12) 
  
  + Lcom/android/volley/toolbox/j;
  + Lf7/g;
  + Lo7/c;
  + Ls2/K;
  + [Ld0/d0;
  + [Lf7/c;
  + [Ln6/L;
  + [Ln6/s2;
  + [Ln8/Q;
  + [Ls2/J;
  + [Ls2/l;
  + [Ls2/u;
  + [Ls8/A;
  + [Ls8/C;
  + [Ls8/y;
  + [Lx3/n;
  
  - Ls8/P;
  - [Ld0/W;
  - [Ln6/K;
  - [Ln6/r2;
  - [Ln8/P;
  - [Ls2/I;
  - [Ls2/k;
  - [Ls2/t;
  - [Ls8/B;
  - [Ls8/G;
  - [Ls8/z;
  - [Lx3/m;
  

METHODS:

   old   │ new   │ diff             
  ───────┼───────┼──────────────────
   61039 │ 61051 │ +12 (+1005 -993) 
  
  + A3.k f(Context, Looper, g1, Object, i, j) → c
  + A3.k g(Context, Looper, g1, Object, i, j) → c
  + C.e F(b, r) → b
  + Ca.b C(Object) → b
  + Ca.c C(Object) → c
  + Ca.i C(int) → byte[]
  + Ca.i D(h) → byte[]
  + Ca.i E(Object) → i
  + Ca.i F() → j
  + Ca.j C(Object) → j
  + E9.b e0(b) → b
  + I7.c <init>(FinancialConnectionsSheetNativeActivity, V, A, z)
  + J8.h H(b) → b
  + Ja.a a(b) → b
  + Ja.b a(b) → b
  + Ka.q C() → byte[]
  + Ka.r C() → byte[]
  + Ka.v C() → byte[]
  + M4.f j(a, g, D, q, int)
  + N3.a B(View, int) → boolean
  + N3.a i(View, int) → int
  + N3.a j(View, int) → int
  + N3.a s(View) → int
  + N3.a w(View, int)
  + N3.a x(int)
  + N3.a y(View, int, int)
  + N3.a z(View, float, float)
  + N5.V a(L2, H0, t2, d) → Object
  + P3.b B(View, int) → boolean
  + P3.b i(View, int) → int
  + P3.b j(View, int) → int
  + P3.b s(View) → int
  + P3.b t() → int
  + P3.b x(int)
  + P3.b y(View, int, int)
  + P3.b z(View, float, float)
  + S7.H d() → g
  + S7.H e(c)
  + S7.H f(x, String, String)
  + U3.b E(int)
  + U3.b F(Typeface, boolean)
  + V7.H <init>(m, c)
  + Z8.O0 <init>(a, m, g, a, boolean, boolean, f, int, int)
  + a7.Q <init>(String, String, String, String, z0, Integer, String)
  + a7.S <init>(String, String, String, z0)
  + a7.T <init>(String, String, String, String, z0)
  + androidx.activity.z <init>(A)
  + c4.j H(Object) → float
  + c4.j W(Object, float)
  + com.android.volley.toolbox.i A(J[], q) → A
  + com.android.volley.toolbox.i B(Throwable, Context) → String
  + com.android.volley.toolbox.i C(Throwable) → c
  + com.android.volley.toolbox.i D(List) → JSONArray
  + com.android.volley.toolbox.i a(a, m, f, q, int)
  + com.android.volley.toolbox.i b(m, f, q, int)
  + com.android.volley.toolbox.i c(f, f, q, int)
  + com.android.volley.toolbox.i d(int) → A
  + com.android.volley.toolbox.i e(String, boolean, a, m, boolean, boolean, q, int, int)
  + com.android.volley.toolbox.i f(v2, m, f, q, int)
  + com.android.volley.toolbox.i h(int, int) → long
  + com.android.volley.toolbox.i i(m, f, q, int)
  + com.android.volley.toolbox.i j(List, q, int)
  + com.android.volley.toolbox.i k(g, q, int)
  + com.android.volley.toolbox.i l(String, long, z, boolean, boolean, boolean, q, int)
  + com.android.volley.toolbox.i m(e, String, List)
  + com.android.volley.toolbox.i n(j, Object, int, Object, q, int)
  + com.android.volley.toolbox.i o(Context) → A
  + com.android.volley.toolbox.i p(CaptureRequest_Builder, X)
  + com.android.volley.toolbox.i q(y, CameraDevice, Map) → CaptureRequest
  + com.android.volley.toolbox.i r(int, int)
  + com.android.volley.toolbox.i s(v0) → p
  + com.android.volley.toolbox.i t(p, long, List) → j
  + com.android.volley.toolbox.i u() → boolean
  + com.android.volley.toolbox.i v(InputStream, int, a) → byte[]
  + com.android.volley.toolbox.i w(Context, String) → String
  + com.android.volley.toolbox.i x(Context, x)
  + com.android.volley.toolbox.i y(Throwable)
  + com.android.volley.toolbox.i z(J)
  + com.android.volley.toolbox.j A(Context, int) → String
  + com.android.volley.toolbox.j B() → Se
...✂

@tillh-stripe tillh-stripe force-pushed the tillh/pass-link-mode-to-las-creation branch from 18ee455 to d9f9513 Compare October 16, 2024 16:47
@tillh-stripe tillh-stripe force-pushed the tillh/pass-link-mode-to-las-creation branch from d9f9513 to 4f72957 Compare October 16, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant