Metrics via API, per-cluster Prometheus Config, OCP monitoring support #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
force-pushed
the
multi-prometheus
branch
2 times, most recently
from
e4f3f90
to
aaf2b96
Compare
Signed-off-by: Michael Edgar <[email protected]>
MikeEdgar
force-pushed
the
multi-prometheus
branch
from
aaf2b96
to
c9d7e7a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the responsibility of metrics retrieval back to the API layer and returns them as an attribute of a KafkaCluster response. Additionally, configuration is available to allow each Kafka cluster to reference a particular Prometheus instance as its source for metrics.
Via the operator, users may configure metrics sources as standalone (where they must provide a URL and possible credentials), embedded (where the operator will deploy an un-secured Prometheus instance), or OpenShift monitoring. Support for OpenShift monitoring requires that user-defined projects are monitored by the OCP platform Prometheus [1] and also that the Console serviceAccount is granted access to the Thanos Querier route. This access will be setup automatically by the operator when using this type of metrics source.
In the UI , there are some additional display changes as well. Byte values will include a fixed number of decimal positions depending on the integer value. For example 1 GiB will display as 1.00 GiB. Additionally, the full list of broker states is handled besides just
Running, formerly displayed asStable.[1] https://docs.openshift.com/container-platform/4.16/observability/monitoring/enabling-monitoring-for-user-defined-projects.html