Add link to the reset offset learning resource page #1048
Conversation
Signed-off-by: hemahg <[email protected]>
| <ExternalLink testId={"learn_to_shutdown_members"} href={"https://docs.redhat.com/en/documentation/red_hat_streams_for_apache_kafka/2.7/html-single/kafka_configuration_tuning/index#managing_offset_policy"}> | ||
| {t("learn_to_shutdown_members")} | ||
| </ExternalLink> |
There was a problem hiding this comment.
The label and link should maybe go under learning.labels and learning.links. We should also have a link to something in the Apache Kafka documentation for upstream.
There was a problem hiding this comment.
@MikeEdgar Is the phrase "Learn how to shut down members" correct to include under learning resources?
There was a problem hiding this comment.
@hemahg , yes that seems good.
There was a problem hiding this comment.
Isn't the wording a bit... aggressive? Not a native speaker here, but it feels that way
There was a problem hiding this comment.
are you referring to https://docs.google.com/spreadsheets/d/1R7sX5cSAxzbu87uHNolBfa9EF31YD8n3Z3WpsFirAWU/edit?gid=0#gid=0 doc?
There was a problem hiding this comment.
Yeah, perhaps something like "Learn how to stop consumers" would be better? I'm not sure there is documentation specific to that since it is very dependent on how the consumers are coded. I don't think the link about managing offset policy matches the label.
There was a problem hiding this comment.
@shirimordechay, We've been discussing the phrasing for the learning resource, and I wanted to get some additional feedback. @MikeEdgar suggested "Learn how to stop consumers" as a more appropriate phrase, but I'd like to make sure everyone is on board with this change. Do you have any thoughts or suggestions for improving the wording or can help find relevant documentation links?
There was a problem hiding this comment.
Rephrasing sounds good to me. I believe the doc link is the one @[email protected] has provided, but I'm assuming we'll have a new link for GA. need to confirm that with Paul.
There was a problem hiding this comment.
Update the phrase as per @MikeEdgar suggestion, there is no specific document to shutdown the consumer group members
Signed-off-by: hemahg <[email protected]>
|
Add link to the reset offset learning resource page